This is not GitHub.com

Like what you see? Install OctoLinker now!

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully shutdown: exit after server is closed #418

Merged
merged 4 commits into from Jul 30, 2021
Merged

Gracefully shutdown: exit after server is closed #418

merged 4 commits into from Jul 30, 2021

Conversation

@Kikobeats
Copy link
Contributor

@Kikobeats Kikobeats commented Oct 5, 2019

If process.exit() is not called explicitly, the server is still waiting a kill signal

Closes #407

@javivelasco javivelasco self-requested a review Oct 7, 2019
@hnqlvs
Copy link

@hnqlvs hnqlvs commented Oct 21, 2019

Is this getting merged any time soon? 🤓

@antoniojps
Copy link

@antoniojps antoniojps commented Mar 9, 2020

Any updates on this?

@jlsjonas
Copy link

@jlsjonas jlsjonas commented Sep 23, 2020

@javivelasco Is there any reason this simple (but significant) fix has been stuck in an approved PR for almost a year?

@shuding shuding merged commit 9e0fbda into vercel:master Jul 30, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants