This is not GitHub.com

Like what you see? Install OctoLinker now!

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pMapSkip #39

Merged
merged 9 commits into from Jun 28, 2021
Merged

Add pMapSkip #39

merged 9 commits into from Jun 28, 2021

Conversation

@Richienb
Copy link
Contributor

@Richienb Richienb commented Jun 26, 2021

Fixes #38

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
index.d.ts Show resolved Hide resolved
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Jun 27, 2021

I'm not sold on calling it just skip when it's a named export. Either a more verbose name or put it on pMap. I think I would prefer the former.

@Richienb
Copy link
Contributor Author

@Richienb Richienb commented Jun 27, 2021

I'm not sold on calling it just skip when it's a named export. Either a more verbose name or put it on pMap. I think I would prefer the former.

Maybe pMapSkip?

readme.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Jun 27, 2021

Maybe pMapSkip?

Yeah, I cannot think of anything better.

@Richienb Richienb changed the title Add .skip Add pMapSkip Jun 27, 2021
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb requested a review from sindresorhus Jun 27, 2021
readme.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Jun 28, 2021

Can you fix the merge conflict?

Richienb and others added 3 commits Jun 28, 2021
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@Richienb Richienb requested a review from sindresorhus Jun 28, 2021
@sindresorhus sindresorhus merged commit c9c0882 into sindresorhus:main Jun 28, 2021
2 checks passed
@Richienb
Copy link
Contributor Author

@Richienb Richienb commented Jul 23, 2021

@sindresorhus Could you release this for now?

@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Jul 23, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants