This is not GitHub.com

Like what you see? Install OctoLinker now!

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor example improvement #37

Merged
merged 1 commit into from Jun 6, 2021
Merged

Conversation

@papb
Copy link
Contributor

@papb papb commented Jun 6, 2021

No description provided.

@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Jun 6, 2021

Got requires the protocol now.

@papb
Copy link
Contributor Author

@papb papb commented Jun 6, 2021

@sindresorhus, please look again, that string is not being passed to got. It is being passed to a function expecting a username. I'm pretty sure the correct username is sindresorhus and not https://sindresorhus, right?

@sindresorhus sindresorhus reopened this Jun 6, 2021
@sindresorhus sindresorhus merged commit 9e11914 into sindresorhus:main Jun 6, 2021
2 checks passed
2 checks passed
@github-actions
Node.js 14
Details
@github-actions
Node.js 12
Details
@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Jun 6, 2021

You're absolutely right.

@papb papb deleted the papb:improve-example branch Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants